/usr/local/perl/lib/site_perl/5.8.5/Perl/Critic/Policy/ControlStructures/ProhibitUnreachableCode.pm

NAME

Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode

DESCRIPTION

This policy prohibits code following a statement which unconditionally alters the program flow. This includes calls to exit, die, return, next, last and goto. Due to common usage, croak and confess from the Carp manpage are also included.

Code is reachable if any of the following conditions are true:

Flow-altering statement has a conditional attached to it
Statement is on the right side of an operator &&, ||, and, or or.
Code is prefixed with a label (can potentially be reached via goto)
Code is a subroutine

EXAMPLES

  # not ok

  exit;
  print "123\n";

  # ok

  exit if !$xyz;
  print "123\n";

  # not ok

  for ( 1 .. 10 ) {
      next;
      print 1;
  }

  # ok

  for ( 1 .. 10 ) {
      next if $_ == 5;
      print 1;
  }

  # not ok

  sub foo {
      my $bar = shift;
      return;
      print 1;
  }

  # ok

  sub foo {
      my $bar = shift;
      return if $bar->baz();
      print 1;
  }

  # not ok

  die;
  print "123\n";

  # ok

  die;
  LABEL: print "123\n";

  # not ok

  croak;
  do_something();

  # ok

  croak;
  sub do_something {}

AUTHOR

Peter Guzis <pguzis@cpan.org>

COPYRIGHT