| /usr/local/perl/lib/site_perl/5.8.5/Perl/Critic/Policy/InputOutput/ProhibitReadlineInForLoop.pm |
Perl::Critic::Policy::InputOutput::ProhibitReadlineInForLoop
Using the readline operator in a for or foreach loop is very
slow. The iteration list of the loop creates a list context,
which causes the readline operator to read the entire input stream
before iteration even starts. Instead, just use a while loop,
which only reads one line at a time.
for my $line ( <$file_handle> ){ do_something($line) } #not ok
while ( my $line = <$file_handle> ){ do_something($line) } #ok
Jeffrey Ryan Thalhammer <thaljef@cpan.org>
Copyright (c) 2005-2007 Jeffrey Ryan Thalhammer. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.
| /usr/local/perl/lib/site_perl/5.8.5/Perl/Critic/Policy/InputOutput/ProhibitReadlineInForLoop.pm |